Repository navigation
Embed the sumtype analyzer - #36
Merged
Merged
Conversation
A type switch over a sum type must cover every variant, and Go reports no error when one is missing. go-check-sumtype finds the omission, and its upstream analyzer is a plain go/analysis analyzer. The analyzer exports a package fact, and the analysistest driver checks a fact against a want comment, so the testdata names the fact that the package exports as well as the diagnostic that each omission produces. Change-Id: If942120589f01e42925d43b37ff6f6e9e902dcd1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.